Rollup of 8 pull requests #140122

ChrisDenton · 2025-04-21T15:56:01Z

Successful merges:

fix missing word in comment #139946 (fix missing word in comment)
SystemTime doc tweaks #139982 (SystemTime doc tweaks)
docs(LocalKey<T>): clarify that T's Drop shouldn't panic #140009 (docs(LocalKey): clarify that T's Drop shouldn't panic)
Don't ICE on pending obligations from deep normalization in a loop #140021 (Don't ICE on pending obligations from deep normalization in a loop)
Relocate tests in tests/ui #140029 (Relocate tests in tests/ui)
Fix autodiff debug builds #140030 (Fix autodiff debug builds)
Use output_base_dir for mir_dump_dir #140120 (Use output_base_dir for mir_dump_dir)
Document why CodeStats::type_sizes is public #140121 (Document why CodeStats::type_sizes is public)

r? @ghost
@rustbot modify labels: rollup

…ce functions

… r=jhpratt fix missing word in comment a very simple fix, rectifying a situation in which a word was accidentally .

…ratt SystemTime doc tweaks * Change the `UNIX_EPOCH` link in the `SystemTime` docs to point to the associated constant, not the module level constant. The former seems to be the recommended way to access it, since aiui the only reason the module constant exists in the first place is that associated constants weren't stable yet at the time. * Reword the comment in the `SystemTime` example - "an error occurred!" is a tad misleading; I feel like it implies a system error out of our control while `SystemTimeError` is more of a logic error. I was originally just gonna do the first thing but I noticed the second and figured I may as well. I'm also somewhat surprised that there aren't more in-depth module level docs for `std::time`; they don't even mention `SystemTime` at all. I might make another PR for that but mainly just wanted to flag it.

docs(LocalKey<T>): clarify that T's Drop shouldn't panic Clarify that should a TLS destructor panics, the process will abort. Also, an abort may be obfuscated as the process can be terminated with `SIGSEGV` or [`STATUS_STACK_BUFFER_OVERRUN`](https://devblogs.microsoft.com/oldnewthing/20190108-00/?p=100655) (i.e., `SIGABRT` is not guaranteed), so explicitly prints that the process was aborted. Context: https://users.rust-lang.org/t/status-stack-buffer-overrun-on-windows-without-any-usage-of-unsafe/128417 ``@rustbot`` label -T-compiler

…r=lcnr Don't ICE on pending obligations from deep normalization in a loop See the comment I left inline in `compiler/rustc_trait_selection/src/traits/normalize.rs`. Fixes rust-lang#133868 r? lcnr

Relocate tests in `tests/ui` Part of rust-lang#133895 Moved tests from a top-level directory into a more appropriate subdirectory. If there is anything else that could be improved, please let me know! r? jieyouxu

Fix autodiff debug builds r? `@oli-obk` closes: rust-lang#139704 Tracking: - rust-lang#124509

…eyouxu Use `output_base_dir` for `mir_dump_dir` It just occurred to me that the problem might be due to multiple revisions using the same dump directory (and therefore deleting the other revision's dir). This fixes that by simply using the normal per-test output directory, which is revision safe.

…youxu Document why CodeStats::type_sizes is public As indicated in [this comment](rust-lang#139876 (comment)) from rust-lang#139876 > Need some comment, otherwise this pub can be eventually removed as unused. r? `@nnethercote`

ChrisDenton · 2025-04-21T15:56:26Z

@bors r+ rollup=never p=5

bors · 2025-04-21T15:56:29Z

📌 Commit 77325f5 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2025-04-21T16:14:13Z

⌛ Testing commit 77325f5 with merge 8f2819b...

bors · 2025-04-21T19:27:09Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 8f2819b to master...

rust-timer · 2025-04-21T19:29:24Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139946	fix missing word in comment	`3acaa8831d7b7dab6f07ab63f1ce1bc24e0ade39` (link)
#139982	SystemTime doc tweaks	`537d019997ec3b47cf6bcbc077e68a4a3437d09b` (link)
#140009	docs(LocalKey): clarify that T's Drop shouldn't panic	`396e92a14d3c48b0b886cdde90d1626fd89c0fe4` (link)
#140021	Don't ICE on pending obligations from deep normalization in…	`273cfcf003f2638361234c48f11396eade13337e` (link)
#140029	Relocate tests in `tests/ui`	`2a6dc6a54edff011f3eef4d42b7fec7fa6c30441` (link)
#140030	Fix autodiff debug builds	`fcaa631b10f463aabf00d11cd94db8d53249ce94` (link)
#140120	Use `output_base_dir` for `mir_dump_dir`	`e190185e6541b44c90bdc4cd8783169e36f0b44a` (link)
#140121	Document why CodeStats::type_sizes is public	`c842d533cdeaeea481a40a22920c9f54112ae8e8` (link)

previous master: c8f9423028

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-04-21T19:29:29Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c8f9423 (parent) -> 8f2819b (this PR)

Test differences

Show 128 test diffs

Stage 1

[crashes] tests/crashes/133868.rs: pass -> [missing] (J1)
[ui] tests/ui/borrowck/writing-to-immutable-vec.rs: [missing] -> pass (J1)
[ui] tests/ui/deref-non-pointer.rs: pass -> [missing] (J1)
[ui] tests/ui/deref-patterns/deref-non-pointer.rs: [missing] -> pass (J1)
[ui] tests/ui/lazy-and-or.rs: pass -> [missing] (J1)
[ui] tests/ui/list.rs: pass -> [missing] (J1)
[ui] tests/ui/minus-string.rs: pass -> [missing] (J1)
[ui] tests/ui/or-patterns/lazy-and-or.rs: [missing] -> pass (J1)
[ui] tests/ui/recursion/recursive-enum-box.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/deep-norm-pending.rs: [missing] -> pass (J1)
[ui] tests/ui/typeck/minus-string.rs: [missing] -> pass (J1)
[ui] tests/ui/writing-to-immutable-vec.rs: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/borrowck/writing-to-immutable-vec.rs: [missing] -> pass (J0)
[ui] tests/ui/deref-non-pointer.rs: pass -> [missing] (J0)
[ui] tests/ui/deref-patterns/deref-non-pointer.rs: [missing] -> pass (J0)
[ui] tests/ui/lazy-and-or.rs: pass -> [missing] (J0)
[ui] tests/ui/list.rs: pass -> [missing] (J0)
[ui] tests/ui/minus-string.rs: pass -> [missing] (J0)
[ui] tests/ui/or-patterns/lazy-and-or.rs: [missing] -> pass (J0)
[ui] tests/ui/recursion/recursive-enum-box.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/deep-norm-pending.rs: [missing] -> pass (J0)
[ui] tests/ui/typeck/minus-string.rs: [missing] -> pass (J0)
[ui] tests/ui/writing-to-immutable-vec.rs: pass -> [missing] (J0)
[crashes] tests/crashes/133868.rs: pass -> [missing] (J2)

Additionally, 104 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8f2819b0e3428d0aee05fa60e91e0211c2aea053 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 10601.1s -> 9313.0s (-12.2%)
x86_64-apple-1: 8568.2s -> 7989.6s (-6.8%)
dist-loongarch64-linux: 6725.3s -> 6302.3s (-6.3%)
aarch64-apple: 3722.3s -> 3938.8s (5.8%)
x86_64-msvc-1: 9040.3s -> 8604.9s (-4.8%)
x86_64-rust-for-linux: 2615.0s -> 2732.8s (4.5%)
x86_64-gnu-tools: 5900.2s -> 6159.1s (4.4%)
x86_64-gnu-llvm-19-1: 5337.4s -> 5108.5s (-4.3%)
x86_64-mingw-2: 7137.7s -> 6832.9s (-4.3%)
dist-x86_64-mingw: 7922.0s -> 7609.6s (-3.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-21T20:52:59Z

Finished benchmarking commit (8f2819b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.1%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.5%, 3.8%]	4
Regressions ❌ (secondary)	3.2%	[1.5%, 5.5%]	6
Improvements ✅ (primary)	-1.4%	[-3.4%, -0.6%]	6
Improvements ✅ (secondary)	-5.1%	[-8.1%, -2.2%]	4
All ❌✅ (primary)	-0.1%	[-3.4%, 3.8%]	10

Cycles

Results (primary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.7%, -0.5%]	2

Binary size

Results (primary 0.0%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	29
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 774.633s -> 775.846s (0.16%)
Artifact size: 365.03 MiB -> 365.03 MiB (-0.00%)

mumbleskates and others added 18 commits April 16, 2025 18:53

fix missing word in comment

abf401d

Point UNIX_EPOCH to associated constant in SystemTime docs

88bd191

Be more specific about the error in the SystemTime example

34573d6

LocalKey<T>: document that the dtor should not panic

0d56e3e

rtprintpanic: clarify that the error is aborting the process

17b7d63

Only consider MonoItem::Fn when preventing inlining for autodiff sour…

b3739f3

…ce functions

Don't ICE on pending obligations from deep normalization in a loop

47911eb

Cleaned up 5 tests in tests/ui

dd2d6b2

Use output dir for mir_dump_dir

5e202a3

Document why CodeStats::type_sizes is public

619ed15

Rollup merge of rust-lang#139946 - mumbleskates:any-fix-missing-word,…

6925d2f

… r=jhpratt fix missing word in comment a very simple fix, rectifying a situation in which a word was accidentally .

Rollup merge of rust-lang#140021 - compiler-errors:no-deep-norm-ice, …

f79eef9

…r=lcnr Don't ICE on pending obligations from deep normalization in a loop See the comment I left inline in `compiler/rustc_trait_selection/src/traits/normalize.rs`. Fixes rust-lang#133868 r? lcnr

Rollup merge of rust-lang#140029 - reddevilmidzy:move-test, r=jieyouxu

f8c67c6

Relocate tests in `tests/ui` Part of rust-lang#133895 Moved tests from a top-level directory into a more appropriate subdirectory. If there is anything else that could be improved, please let me know! r? jieyouxu

Rollup merge of rust-lang#140030 - EnzymeAD:autodiff-debug, r=jieyouxu

c43b82f

Fix autodiff debug builds r? `@oli-obk` closes: rust-lang#139704 Tracking: - rust-lang#124509

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2025

bors merged commit 8f2819b into rust-lang:master Apr 21, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 21, 2025

ChrisDenton deleted the rollup-qsj6xu0 branch April 21, 2025 19:28

bors mentioned this pull request Apr 21, 2025

deduplicate abort implementations #139103

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #140122

Rollup of 8 pull requests #140122

ChrisDenton commented Apr 21, 2025

ChrisDenton commented Apr 21, 2025

bors commented Apr 21, 2025

bors commented Apr 21, 2025

bors commented Apr 21, 2025

rust-timer commented Apr 21, 2025

github-actions bot commented Apr 21, 2025

Stage 1

Stage 2

rust-timer commented Apr 21, 2025

Rollup of 8 pull requests #140122

Rollup of 8 pull requests #140122

Conversation

ChrisDenton commented Apr 21, 2025

ChrisDenton commented Apr 21, 2025

bors commented Apr 21, 2025

bors commented Apr 21, 2025

bors commented Apr 21, 2025

rust-timer commented Apr 21, 2025

github-actions bot commented Apr 21, 2025

Test differences

Stage 1

Stage 2

Job duration changes

rust-timer commented Apr 21, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size